-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
promote to prod #580
Merged
promote to prod #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add rETH and weETH to pricing assets
add event emitter to optimism
Multiple Quote Tokens support for FXPools: FXPoolDeployerTracker
update graph and grafting
staging dev
fix spec version for pruned deployments
danielmkm
approved these changes
Apr 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love the detailed and clear writeup and testing instructions. Looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We had an issue with
graph-node
(graphprotocol/graph-node#5308) which delayed this release.I've done a few commits todev
to organize everything but TLDR the plan is: we're promoting the staging pruned version to both production endpoints -prune set to last 1.5M blocks = 1 month. The only service we know that does time-travel queries is Snapshot and a month of data is more than enough for them - we've done this same thing in the past as a workaround for another issue and didn't have any trouble.Actually, Polygon unpruned has been syncing quite fast so I don't think we have to promote the pruned version to both production endpoints. @danielmkm if you can leave an approval here I will only merge when Polygon unpruned is synced which should happen by the end of my day.
Besides, GH actions for building and linting are expected to fail - this PR bumps the Node version and should fix it.
How should this be tested?
FXPoolDeployer
contractFXPoolDeployer
contractdev
->master