feat: add liquidity tabs2 #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
groninge01
reviewed
Dec 4, 2024
| !isStandardOrUnderlyingRootToken(pool, token2) | ||
| ) { | ||
| return false | ||
| } |
There was a problem hiding this comment.
const token1IsStandard = isStandardOrUnderlyingRootToken(pool, token1)
const token2IsStandard = isStandardOrUnderlyingRootToken(pool, token2)
if (token1IsStandard === token2IsStandard) {
return false
}
groninge01
reviewed
Dec 4, 2024
packages/lib/shared/components/btns/button-group/ButtonGroup.tsx
Outdated
Show resolved
Hide resolved
groninge01
reviewed
Dec 4, 2024
| <Box flex="1" key={`button-group-option-${option.value}`}> | ||
| <GroupOptionButton | ||
| isActive={isActive} | ||
| key={`button-group-option-${option.value}`} |
There was a problem hiding this comment.
key is probably not needed here
There was a problem hiding this comment.
If we had multiple options with no tabTooltipLabel, we would need that key do differentiate the different Box components, wouldn't we?
There was a problem hiding this comment.
the key is already on the parent Box, so not needed on the child GroupOptionButton
groninge01
approved these changes
Dec 4, 2024
| bg="transparent" | ||
| id={`button-group-${option.value}`} | ||
| isDisabled={option.disabled} | ||
| key={`button-group-option-${option.value}`} |
There was a problem hiding this comment.
i think this key is also probably not needed
|
|
||
| function IconPopover({ option }: { option: ButtonGroupOption }) { | ||
| if (option.tabTooltipLabel) return null | ||
| if (!option.iconTooltipLabel) return null |
There was a problem hiding this comment.
if (option.tabTooltipLabel || !option.iconTooltipLabel) return null
packages/lib/shared/components/btns/button-group/ButtonGroup.tsx
Outdated
Show resolved
Hide resolved
packages/lib/shared/components/btns/button-group/ButtonGroup.tsx
Outdated
Show resolved
Hide resolved
| let errorMessage = 'Unexpected error. Please ask for support' | ||
| let proportionalLabel = 'Please use proportional mode.' | ||
|
|
||
| if (!error) return |
There was a problem hiding this comment.
move this to the top of the function
| import { BalAlertLink } from '../alerts/BalAlertLink' | ||
| import { ErrorAlert } from './ErrorAlert' | ||
| import { useAddLiquidity } from '@repo/lib/modules/pool/actions/add-liquidity/AddLiquidityProvider' | ||
|
|
||
| type Props = AlertProps & { | ||
| error?: Error | null |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.