Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process results on join #174

Closed
wants to merge 2 commits into from
Closed

Conversation

anotherpit
Copy link

Currently find() uses processor to cast result records, and join() does not. This PR adds processing to parent records of join() results. Child records still need to be processed.

@devinivy
Copy link
Contributor

@anotherpit I think that makes sense! Do you mind writing a failing test on waterline-adapter-tests?

Also, there's a failing test CI picked-up. I think it's likely a timing issue. Going to re-run the CI. For reference, though, it was:

1) autoIncrement attribute feature should auto generate unique values even when values have been set:
     [Error (E_VALIDATION) 1 attribute is invalid] Invalid attributes sent to undefined:
 • id
   • A record with that `id` already exists (`5`).

@anotherpit
Copy link
Author

Moved to #204 to isolate the PR from unrelated changes in my master branch

@anotherpit anotherpit closed this Oct 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants