Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update adapter.js #196

Closed
wants to merge 2 commits into from
Closed

Update adapter.js #196

wants to merge 2 commits into from

Conversation

Ozhvankov
Copy link

fix stream function:
change to new query builder
line 930-939
new Query --> new Sequel

fix stream function:
change to new query builder
line 930-939 
new Query --> new Sequel
@devinivy
Copy link
Contributor

Hey @Ozhvankov, thanks for your contribution! A couple questions,

  • The build doesn't pass because ./query as required doesn't exist inside the repo.
  • Can you explain the change around removing formattedErr.originalError = err;?
  • Can you remove unused commented code and console.logs?
  • Does this resolve a particular github issue?

bug fix of path-1
thanx for U "focus" on removing formattedErr.originalError = err;
its our mistake
@Ozhvankov
Copy link
Author

bug fix of patch-1
thanx for U "focus" on removing formattedErr.originalError = err;
its our mistake

@devinivy
Copy link
Contributor

Just leaving this build failure here, but I think it's a timing issue that needs to be fixed in the adapter tests. I'm going to re-run the build, and hopefully it will pass.

  autoIncrement attribute feature
  ✓ should auto generate unique values
  1) should auto generate unique values even when values have been set
Error (E_VALIDATION) :: 1 attribute is invalid
Error (E_VALIDATION) :: 1 attribute is invalid
error: duplicate key value violates unique constraint "autoIncTable_pkey"
    at Socket.<anonymous> (_stream_readable.js:765:14)
    at emitReadable_ (_stream_readable.js:427:10)
    at emitReadable (_stream_readable.js:423:5)
    at readableAddChunk (_stream_readable.js:166:9)
    at Socket.Readable.push (_stream_readable.js:128:10)
    at TCP.onread (net.js:529:21)
Invalid attributes sent to undefined:
 • id
   • A record with that `id` already exists (`5`).
  262 passing (4s)
  2 pending
  1 failing
  1) autoIncrement attribute feature should auto generate unique values even when values have been set:
     [Error (E_VALIDATION) 1 attribute is invalid] Invalid attributes sent to undefined:
 • id
   • A record with that `id` already exists (`5`).
  Error (E_VALIDATION) :: 1 attribute is invalid
  Error (E_VALIDATION) :: 1 attribute is invalid
  error: duplicate key value violates unique constraint "autoIncTable_pkey"
      at Socket.<anonymous> (_stream_readable.js:765:14)
      at emitReadable_ (_stream_readable.js:427:10)
      at emitReadable (_stream_readable.js:423:5)
      at readableAddChunk (_stream_readable.js:166:9)
      at Socket.Readable.push (_stream_readable.js:128:10)
      at TCP.onread (net.js:529:21)

@particlebanana
Copy link
Contributor

Whoops sorry @Ozhvankov didn't see this. I added #221 which adds the pg-query-stream dependency along with these patches. We need to add some tests and get it documented before it can be merged though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants