Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#39: ignore columns with primaryKey set to false when determining foreignKeys #41

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

#39: ignore columns with primaryKey set to false when determining foreignKeys #41

wants to merge 2 commits into from

Conversation

janhapke
Copy link

@janhapke janhapke commented Mar 8, 2016

Here is the fix together with the unit tests which no longer fail.

@devinivy
Copy link

devinivy commented Mar 9, 2016

@particlebanana node v5 consistently choking on the integration tests for some reason. PR looks good to me 👍.

Running integration tests...
rm -rf node_modules/waterline-adapter-tests/node_modules/waterline;
ln -s "/home/travis/build/balderdashy/waterline-schema/test_integration/waterline-master" node_modules/waterline-adapter-tests/node_modules/waterline;
ln: failed to create symbolic link `node_modules/waterline-adapter-tests/node_modules/waterline': No such file or directory
make[1]: *** [test-integration] Error 1
make[1]: Leaving directory `/home/travis/build/balderdashy/waterline-schema/test_integration/waterline-master'
npm ERR! Test failed.  See above for more details.
make: *** [test-integration] Error 1
npm ERR! Test failed.  See above for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants