V4 #52
V4 #52
Conversation
|
We might also want a check from supervisor devs in this? https://github.com/balena-os/balena-supervisor/blob/master/package.json#L42 |
|
The supervisor only uses balena-compose for setting up its development image @otaviojacobi. This change seems to be related to the typing improvements on Pine, I don't think that will affect the supervisor but I'll check it out. Thanks for bringing it to my attention! |
|
hey @pipex I think the typing pr is a follow up to this, but the more "breaking" thing here that could in impact is in fact this commit: 40da06d it just effectively expects the engine to break with v1 manifests (no changes on balena-compose itself, but we should be aware that this will happen on more recent docker releases) Also important is probably this: 8ce4ee1 we are using native fetch api to talk to the registry instead of request library which could potentially change something as fetch http client is far lighter/less feature full (but so far we haven't seen any change) |
| retry?: RetryParameters; | ||
| } | ||
|
|
||
| export function createClient(config: ClientConfig): PinejsClientRequest { |
There was a problem hiding this comment.
Now that this is gone, there is a comment at line 58/28 that needs to be updated.
Change-type: major
Change-type: major
Change-type: patch
tar files created with mac computers are including a lsetxattr header that docker engine doesn't seem to be able to handle, this just recreate the tar files without such headers See: moby/moby#47517 See: https://eclecticlight.co/2023/03/13/ventura-has-changed-app-quarantine-with-a-new-xattr/ Change-type: patch
Docker Image Format v1 and Docker Image manifest version 2, schema 1 support is disabled by default and will be removed in an upcoming release. Change-type: major
|
@otaviojacobi are we fine w/ this? Are we just pending an approval from someone? |
|
@thgreasi I have tested pushing to a local device, pushing to cloud, builiding & deploying to cloud too. So IMHO, yes, we are just missing a review/approval, please notice that I also ammended one of your commits to address Akis's comment. |
|
Thanks for the info @otaviojacobi. This should not cause any issues on the supervisor the supervisor as this module is not used in production, it is only used to build supervisor images for testing the supervisor on a live device (npm run sync) |
|
Cool @otaviojacobi I had tested exactly those things as well 👍 (The node resolver change ended up being the hardest thing to test) |
Change-type: major