Use dd and blkid to get the partition label at an offset into the image #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This shaves off around 7 seconds for fetchign partition info in my local testing Change-type: patch
Page-
force-pushed
the
dd-blkid-part-labels
branch
from
4aaf7b4
to
92fb951
Compare
|
Does this work for MBR as well as GPT formatted disks? |
|
Do you know which version of balenaOS uses MBR/GPT so they can be tested @jakogut ? |
|
@Page- The only gpt formatted images I'm aware of currently are the ones in balena-generic. @alexgg Do you know of any others? |
|
@Page- Ah, the Jetson images are GPT formatted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This shaves off around 7 seconds for fetchign partition info in my
local testing
Change-type: patch