Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update @balena/lint to 9.x #27

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Update @balena/lint to 9.x #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,13 +35,13 @@
"prepare": "node -e \"try { (await import('husky')).default() } catch (e) { if (e.code !== 'ERR_MODULE_NOT_FOUND') throw e }\" --input-type module"
},
"devDependencies": {
"@balena/lint": "^8.2.7",
"husky": "^9.1.5",
"lint-staged": "^15.2.9",
"typescript": "^5.5.4"
"@balena/lint": "^9.0.1",
"husky": "^9.1.6",
"lint-staged": "^15.2.10",
"typescript": "^5.6.2"
},
"dependencies": {
"@balena/abstract-sql-to-typescript": "^3.1.2",
"@balena/abstract-sql-to-typescript": "^3.3.1",
"@types/chai": "^4.3.19",
"@types/chai-as-promised": "^7.1.8",
"@types/express": "^4.17.21",
Expand Down
14 changes: 7 additions & 7 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ type ExpandToResponse<
>;
}
: // If no $expand is provided, no properties are expanded
// eslint-disable-next-line @typescript-eslint/ban-types -- We do want an empty object but `Record<string, never>` doesn't work because things breaks after it's used in a union, needs investigation
// eslint-disable-next-line @typescript-eslint/no-empty-object-type -- We do want an empty object but `Record<string, never>` doesn't work because things breaks after it's used in a union, needs investigation
{};

// Check if two types are exactly equal, useful for checking against eg exactly `any`
Expand Down Expand Up @@ -212,7 +212,7 @@ export class PineTest<
url: NonNullable<Params<T>['url']>;
} & Params<T>,
): PromiseResult<void>;
public put(params: Params<AnyResource>): PromiseResult<void> {
public put(params: Params): PromiseResult<void> {
return super.put(
params as Parameters<PinejsClientCore<unknown, Model>['put']>[0],
) as PromiseResult<
Expand All @@ -232,7 +232,7 @@ export class PineTest<
url: NonNullable<Params<T>['url']>;
} & Params<T>,
): PromiseResult<void>;
public patch(params: Params<AnyResource>): PromiseResult<void> {
public patch(params: Params): PromiseResult<void> {
return super.patch(
params as Parameters<PinejsClientCore<unknown, Model>['patch']>[0],
) as PromiseResult<
Expand All @@ -252,7 +252,7 @@ export class PineTest<
url: NonNullable<Params<T>['url']>;
} & Params<T>,
): PromiseResult<AnyObject>;
public post(params: Params<AnyResource>): PromiseResult<AnyObject> {
public post(params: Params): PromiseResult<AnyObject> {
return super.post(
params as Parameters<PinejsClientCore<unknown, Model>['post']>[0],
) as PromiseResult<
Expand All @@ -272,7 +272,7 @@ export class PineTest<
url: NonNullable<Params<T>['url']>;
} & Params<T>,
): PromiseResult<void>;
public delete(params: Params<AnyResource>): PromiseResult<void> {
public delete(params: Params): PromiseResult<void> {
return super.delete(
params as Parameters<PinejsClientCore<unknown, Model>['delete']>[0],
) as PromiseResult<
Expand All @@ -290,8 +290,8 @@ export class PineTest<

public request(
...args: Parameters<PinejsClientCore<unknown, Model>['request']>
): PromiseResult<any> {
return super.request(...args) as PromiseResult<any>;
): PromiseResult {
return super.request(...args) as PromiseResult;
}

protected callWithRetry<T>(
Expand Down