Fixes

Change-type: patch
balena-io-modules · Jun 4, 2024 · 952f52b · 952f52b
1 parent 61d5878
commit 952f52b
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 7 deletions.
diff --git a/src/types/big-integer.ts b/src/types/big-integer.ts
@@ -9,7 +9,7 @@ export const types = {
 	},
 };
 
-export type Types = TypeUtils.TsTypes<bigint, bigint>;
+export type Types = TypeUtils.TsTypes<bigint, number | bigint>;
 type DbWriteType = bigint;
 
 export const fetchProcessing: TypeUtils.FetchProcessing<Types['Read']> = (
@@ -18,14 +18,15 @@ export const fetchProcessing: TypeUtils.FetchProcessing<Types['Read']> = (
 	if (data == null) {
 		return data;
 	}
-
+	let value: bigint;
 	if (typeof data === 'bigint') {
-		return data;
+		value = data;
 	} else if (typeof data === 'string' || typeof data === 'number') {
-		return BigInt(data);
+		value = BigInt(data);
+	} else {
+		throw new Error('Fetched bigint is not valid: ' + typeof data);
 	}
-
-	throw new Error('Fetched bigint is not valid: ' + typeof data);
+	return value;
 };
 
 export const nativeFactTypes = {

diff --git a/src/types/big-serial.ts b/src/types/big-serial.ts
@@ -24,7 +24,7 @@ export const types = {
 	},
 };
 
-export type Types = TypeUtils.TsTypes<bigint, bigint>;
+export type Types = TypeUtils.TsTypes<bigint, number | bigint>;
 type DbWriteType = bigint;
 
 export const validate: TypeUtils.Validate<Types['Write'], DbWriteType> =

diff --git a/test/Big Integer.ts b/test/Big Integer.ts
@@ -9,6 +9,7 @@ helpers.describe('Big Integer', (test) => {
 		test.fetch('1', BigInt(1));
 		test.fetch(BigInt(testBigIntString), BigInt(testBigIntString));
 		test.fetch(testBigIntString, BigInt(testBigIntString));
+		test.fetch({}, new Error('Fetched bigint is not valid: object'));
 	});
 
 	describe('validate', function () {