devices: add device_tag to JSON output #2693
Conversation
otaviojacobi
force-pushed
the
devices-json-device-tag
branch
from
47fbcdd to
677531a
Compare
otaviojacobi
force-pushed
the
devices-json-device-tag
branch
from
677531a to
2bc0030
Compare
otaviojacobi
force-pushed
the
devices-json-device-tag
branch
from
2bc0030 to
3321a83
Compare
otaviojacobi
force-pushed
the
devices-json-device-tag
branch
from
3321a83 to
4eb1aef
Compare
| @@ -116,7 +123,9 @@ export default class DevicesCmd extends Command { | |||
|
|
|||
| if (options.json) { | |||
| const { pickAndRename } = await import('../../utils/helpers'); | |||
| const mapped = devices.map((device) => pickAndRename(device, fields)); | |||
| const mapped = devices.map((device) => | |||
| pickAndRename(device, [...fields, 'device_tag']), | |||
There was a problem hiding this comment.
@thgreasi You probably have more context than I do on this, should the, now being expanded, device_tag have the pickAndRename applied to it? AFAIK this only applies in case of something being formatted with 'a => b' and we probably wouldn't want to change it if this is the tag value of the client?
There was a problem hiding this comment.
@otaviojacobi I think that we only use pickAndRename in this file for consistency reasons and that in this file using pick or pickAndRename has the same outcome since there is no => used in the defined fields.
|
Coming back around to needing this in CI soon, is there anything else I can do to support this process? Thank you! |
|
@bbugh could you please also squash all commits and rebase your branch on top of master before merging so that the changelog only includes just one entry? |
change-type: minor
bbugh
force-pushed
the
devices-json-device-tag
branch
from
b5cef31 to
bd194e6
Compare
change-type: minor
Hello again! 👋
Related to #2692 and #2685, adding
device_tagexpansion to the json output of thedevicescommand, so we can query for devices with a specific device tag to pin a specific release to it.