Use app installation tokens instead of default github token #455
+69
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-type: patch Signed-off-by: Ryan Cooke <[email protected]>
rcooke-warwick
had a problem deploying
to
balena-staging.com
GitHub Actions
Failure
klutchell
reviewed
Nov 29, 2024
| permissions: |- | ||
| { | ||
| "contents": "read", | ||
| "actions": "read", |
There was a problem hiding this comment.
The Flowzone app does not have actions: read IIRC, and neither does the new defaults for the automatic GITHUB_TOKEN. I think we need to decide which is better to use here.
klutchell
reviewed
Nov 29, 2024
| @@ -31,6 +31,9 @@ on: | |||
| jobs: | |||
| yocto: | |||
| name: Yocto | |||
| permissions: | |||
| # Have to explicitly get permission here as not yet supported by gh app tokens | |||
| id-token: write # This is required for requesting the JWT #https://docs.github.com/en/actions/deployment/security-hardening-your-deployments/configuring-openid-connect-in-amazon-web-services#requesting-the-access-token | |||
There was a problem hiding this comment.
Suggested change
| id-token: write # This is required for requesting the JWT #https://docs.github.com/en/actions/deployment/security-hardening-your-deployments/configuring-openid-connect-in-amazon-web-services#requesting-the-access-token | |
| actions: read | |
| contents: read | |
| packages: read | |
| id-token: write # This is required for requesting the JWT #https://docs.github.com/en/actions/deployment/security-hardening-your-deployments/configuring-openid-connect-in-amazon-web-services#requesting-the-access-token | |
| pull-requests: write |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-type: patch