Change the jax random number generator key for 32-bit python #833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves bambinos#832. In theory we can do `2**31` and not `2**31-1` if we would like, the latter seems to run without issue as well, I just kept with the `-1` to be consistent with the current implementation
tjburch
changed the title
|
I'm running CI again. I don't understand why it was cancelled... |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #833 +/- ##
==========================================
- Coverage 90.01% 89.94% -0.08%
==========================================
Files 47 47
Lines 3967 3969 +2
==========================================
- Hits 3571 3570 -1
- Misses 396 399 +3 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #832. See that issue for a full explanation, but long-story-short, the current value of
2**32-1yields an overflow error in 32-bit python.In theory we can do
2**31and not2**31-1if we would like, the former seems to run without issue as well, I just kept with the-1to be consistent with the current implementation.