Add more detail to API exception messages #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So instead of, e.g., "Missing or invalid payment information - Please validate all required payment information." We return: "Missing or invalid payment information - Please validate all required payment information. (State/province does not match country; Shipping state/province does not match country.)"
|
Someone at Bambora please review this. Our company started to use this SDK and when we get error 314 we're unable to relay any details as to why the card couldn't be charged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it was frustrating at times dealing with errors to do with missing or incorrect data, as only the message "title" was being returned via the API Exception class. The REST response includes a
detailsarray, so I've merged that into the returned message here.The formatting is a little arbitrary of course, but it's the best way I could think of to append an unknown number of errors to the message string.