Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expo SDK 48 #84

Open
jimmy123A opened this issue Feb 25, 2023 · 4 comments
Open

Expo SDK 48 #84

jimmy123A opened this issue Feb 25, 2023 · 4 comments

Comments

@jimmy123A
Copy link

The plugin is not working with the latest expo SDK. Are you able to fix, or anyone's up for a PR maybe?

@jakobo
Copy link

jakobo commented Mar 2, 2023

Hey there, maintainer of expo-community-flipper (an upstream dependency) here!

With SDK48, flipper is now officially supported. This means for SDK 48 you should remove the expo-community-flipper dependency and add expo-build-properties.

Most options carry over 1:1 under the new config object, including the ability to specify a semver version if you're using a version of react-native-flipper that differs from the one bundled with your react-native version. If after you've switched to the official build-properties plugin, things still aren't working, can you share the generated Podfile from expo prebuild? It's very helpful to ensure your Flipper is being defined properly when using an Expo setup.

@danieldanielecki
Copy link

I can confirm, after changing from expo-community-flipper to expo-build-properties it's working again.

Before I've seen an error I couldn't find in Google [ios.dangerous]: withIosDangerousBaseMod: Cannot add flipper arguments to the project's ios/Podfile. Please report this with a copy of your project Podfile. You can generate this with the expo prebuild command.

This issue can be closed.

@danieldanielecki
Copy link

PS. Code related to Flipper needs to be removed in AppDelegate.mm and in package.json. However, I couldn't find in the settings Start Measuring.

simulator_screenshot_ADBEA66B-FB75-4525-8CCA-0B102B5052E4

@tamagutchi
Copy link

tamagutchi commented Jul 24, 2023

PS. Code related to Flipper needs to be removed in AppDelegate.mm and in package.json. However, I couldn't find in the settings Start Measuring.

simulator_screenshot_ADBEA66B-FB75-4525-8CCA-0B102B5052E4

Same here. Any solutions regarding the missing Start Measuring option?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants