Add necessary libraries to static executable

[lanza]

If you link against a dylib build (e.g. when building in debug mode)
you'll need these.

[banach-space]

Thank you for this patch, it addresses an import issue! Interestingly, similar problem was recently raised in clang-tutor.

This looks good to me, but I have a small suggestion:

include(AddLLVM)

set(LLVM_LINK_COMPONENTS
LLVMCore
LLVMIRReader
LLVMSupport
LLVMPasses
)

add_llvm_tool(static
 StaticMain.cpp
 ../lib/StaticCallCounter.cpp
 )

This should work 🤞🏻and would be more canonical. Would you be able to try that? Thank you!

[banach-space]

As there's been no traffic here, merging as is. Thank you for contributing @lanza !

[lanza]

Sorry, this got lost in my inbox. But I'm note sure add_llvm_tool is the right thing here. I know recently, for example, yaml2obj stopped working as a distribution target due to changes to add_llvm_tool. I think the rationale is that an llvm_tool is something used for working on llvm as an llvm developer. A tool like this static is one to be used by developers to run optimizations on their code. So something suitable for distribution.

On top of that, add_llvm_such_and_such is a damn minefield of cmake. And I'd definitely slot it in the old-cmake style and not "modern cmake" with it's implicit dependencies on local variables via macros. If it's not needed for a tool to work properly then I'm a fan of avoiding it.

[banach-space]

Yeah, I don't understand the rationale behind various LLVM's CMake APIs. And there isn't much documentation.

add_llvm_tool is not needed here, but it's a different story in clang-tutor. I'm slowly digging into it. I also don't want to use it blindly without understanding exactly why it's needed.

Cheers for all the input!