-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Origin/feat/walletconnect #313
base: main
Are you sure you want to change the base?
Conversation
changed yarn-lock file so that it will prevent confliction. |
Sorry if it were bothering you. |
Hey @0xkf, I'm going to review your PR today. |
Thank you!! yarn-lock.json is as same as before. Could you tell me some advice?? |
Here I am @0xkf, sorry for the delay :) Have you tried running the Indeed, the CI returns an error as well Consequently, I kindly ask you to revert your manual changes on the tip: revert the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, check the yarn.lock
file (have a look here for further explanation #313 (comment))
Hi, @0xjei ,Thank you for your review & advice! I made new branch and tried again but it faied because of viem packages. I will try to make this better, but I would like to hear some advice if it were possible. |
@@ -3,6 +3,7 @@ import { NestFactory } from "@nestjs/core" | |||
import { SwaggerModule, DocumentBuilder } from "@nestjs/swagger" | |||
import { ironSession } from "iron-session/express" | |||
import { AppModule } from "./app/app.module" | |||
import fetch from 'node-fetch'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is not necessary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 definitely not!
Hey @0xkf! Good work, and thank you so much for this PR. I added a comment. To solve the viem issue, try upgrading the typescript version in the client app. Inside the client project, run Before completing the PR, can you always check |
Description
installed wagmi and rainbowkit packages,
then implemented to the rainbowkit connect button.
watching vite rainbow exmple.
Related Issue
Does this introduce a breaking change?
Other information