Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Origin/feat/walletconnect #313

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

0xkf
Copy link

@0xkf 0xkf commented Oct 2, 2023

Description

installed wagmi and rainbowkit packages,
then implemented to the rainbowkit connect button.

watching vite rainbow exmple.

Related Issue

Does this introduce a breaking change?

  • Yes
  • No

Other information

@vplasencia vplasencia requested review from vplasencia and 0xjei October 2, 2023 14:21
@0xkf
Copy link
Author

0xkf commented Oct 3, 2023

changed yarn-lock file so that it will prevent confliction.
Can you review??

@0xkf
Copy link
Author

0xkf commented Oct 3, 2023

@vplasencia @0xjei

@0xkf
Copy link
Author

0xkf commented Oct 3, 2023

Sorry if it were bothering you.
I tried again.

@0xjei
Copy link
Collaborator

0xjei commented Oct 3, 2023

Hey @0xkf, I'm going to review your PR today.

@0xkf
Copy link
Author

0xkf commented Oct 4, 2023

Hey @0xkf, I'm going to review your PR today.

Thank you!!
Actually, it is working well in my local, but it says "All check failed" after semding PR.

yarn-lock.json is as same as before.

Could you tell me some advice??

@0xjei
Copy link
Collaborator

0xjei commented Oct 4, 2023

Hey @0xkf, I'm going to review your PR today.

Thank you!! Actually, it is working well in my local, but it says "All check failed" after semding PR.

yarn-lock.json is as same as before.

Could you tell me some advice??

Here I am @0xkf, sorry for the delay :)

Have you tried running the yarn && yarn build commands from scratch? They return me an error without completing the build process (The command failed for workspaces that are depended upon by other workspaces; can't satisfy the dependency graph).

Indeed, the CI returns an error as well YN0028: │ The lockfile would have been modified by this install, which is explicitly forbidden.

Consequently, I kindly ask you to revert your manual changes on the yarn.lock file and retry in order to have a clean build process! Let us know if you need any help.

tip: revert the yarn.lock to the state before your changes and proceed with a fresh installation of the packages and then run yarn && yarn build.

Copy link
Collaborator

@0xjei 0xjei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, check the yarn.lock file (have a look here for further explanation #313 (comment))

@0xkf
Copy link
Author

0xkf commented Oct 7, 2023

Hi, @0xjei ,Thank you for your review & advice!
As you say, When I hit "yarn && yarn build " it failed.

I made new branch and tried again but it faied because of viem packages.
And it shows "The command failed for workspaces that are depended upon by other workspaces; can't satisfy the dependency graph".

I will try to make this better, but I would like to hear some advice if it were possible.

@@ -3,6 +3,7 @@ import { NestFactory } from "@nestjs/core"
import { SwaggerModule, DocumentBuilder } from "@nestjs/swagger"
import { ironSession } from "iron-session/express"
import { AppModule } from "./app/app.module"
import fetch from 'node-fetch';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is not necessary

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 definitely not!

@vplasencia
Copy link
Member

Hey @0xkf! Good work, and thank you so much for this PR. I added a comment.

To solve the viem issue, try upgrading the typescript version in the client app. Inside the client project, run yarn add typescript. Then this error will be solved, and you will get a new error related to UI.

Before completing the PR, can you always check yarn prettier and if it is necessary, run yarn prettier:write and also yarn lint and fix the problems if any?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants