Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 版本文件拼接错误 #48

Merged
merged 1 commit into from
Aug 5, 2021

Conversation

patokeni
Copy link
Contributor

不太了解inheritsFrom和jar之间的关系,似乎inheritsFrom参数不应该影响版本文件的选取?

@bangbang93
Copy link
Owner

在以前的forge中,安装完成是不会生成jar的,通过inheritsFrom指定继承自哪个版本,取对应的jar文件

@patokeni
Copy link
Contributor Author

了解,另外json中的jar参数代表取versions/{jar}/{jar}.jar还是说其他目录下的jar文件

@xfl03
Copy link
Contributor

xfl03 commented Nov 23, 2020

了解,另外json中的jar参数代表取versions/{jar}/{jar}.jar还是说其他目录下的jar文件

versions/{jar}/{jar}.jar

@patokeni patokeni force-pushed the fix/version-classpath branch from e8a2287 to f343b93 Compare November 23, 2020 10:05
@patokeni patokeni force-pushed the fix/version-classpath branch from f343b93 to e6bafab Compare November 23, 2020 14:49
@patokeni
Copy link
Contributor Author

试了几个版本应该是没有问题了,如果合并的话#47 也可以close了

@ZekerZhayard
Copy link

ZekerZhayard commented Jul 27, 2021

在以前的forge中,安装完成是不会生成jar的,通过inheritsFrom指定继承自哪个版本,取对应的jar文件

@bangbang93 现在官启的行为是会在每个 versions 的子文件夹内补全 inheritsFrom 最终指向的 downloads.client 里的文件;
同时 forge 1.17.1 也利用了这个特性

@bangbang93
Copy link
Owner

近期会准备适配1.17的forge安装和启动

@bangbang93 bangbang93 merged commit 1901508 into bangbang93:master Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants