Backported Cadence clusterMetadata default values fix to 0.20 #1282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also simplified primary cluster rpcAddress to chart value, because the chart value is required to be set for the K8s service so it always exists, no reason to try to default to dockerize env or hardcoded default if the chart value is always set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Backported Cadence clusterMetadata default values fix to 0.20.
Why?
It was broken since 0.18.
Additional context
This is a fix backport onto the 0.20 minor version.
Configurability of
clusterMetadataandclusterInformationincluding setups with multiple clusters will be supported in chart 0.21 (#1278).Also simplified primary cluster
rpcAddressto chart value, because the chart value is required to be set for the K8s service so it always exists, no reason to try to default to dockerize env or hardcoded default if the chart value is always set.Checklist
User guide and development docs updated (if needed)