Skip to content

Commit

Permalink
Rely on Alpine based base image
Browse files Browse the repository at this point in the history
This allows us to have the latest certificates that are needed for ECR
to operate properly in certian setups.
  • Loading branch information
turip committed Apr 1, 2021
1 parent 0dd8ff3 commit e5fc942
Show file tree
Hide file tree
Showing 6 changed files with 14 additions and 10 deletions.
5 changes: 4 additions & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,10 @@ RUN CGO_ENABLED=0 GOOS=linux GOARCH=amd64 GO111MODULE=on go build -a -o manager

# Use distroless as minimal base image to package the manager binary
# Refer to https://github.com/GoogleContainerTools/distroless for more details
FROM ubuntu:20.04
FROM alpine:3.13.4

RUN apk add --update --no-cache ca-certificates

WORKDIR /
COPY --from=builder /workspace/manager .
USER nonroot:nonroot
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ MAIN_PACKAGE ?= main.go

COMMIT_HASH ?= $(shell git rev-parse --short HEAD 2>/dev/null)
BUILD_DATE ?= $(shell date +%FT%T%z)
VERSION ?= 0.1.1
VERSION ?= 0.1.2
LDFLAGS += -X github.com/banzaicloud/imps/internal/version.commitHash=${COMMIT_HASH}
LDFLAGS += -X github.com/banzaicloud/imps/internal/version.buildDate=${BUILD_DATE}
LDFLAGS += -X github.com/banzaicloud/imps/internal/version.version=${VERSION}
Expand Down
4 changes: 2 additions & 2 deletions deploy/charts/imagepullsecrets/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,6 @@ maintainers:
sources:
- https://github.com/banzaicloud/backyards

version: 0.1.1
appVersion: 0.1.1
version: 0.1.2
appVersion: 0.1.2

3 changes: 2 additions & 1 deletion deploy/charts/imagepullsecrets/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,8 @@ spec:
serviceAccountName: {{ include "imagepullsecret-controller.fullname" . }}
containers:
- name: controller
args:
command:
- /manager
- --metrics-addr=:8080
- --enable-leader-election
- --config-namespace={{ .Release.Namespace }}
Expand Down
2 changes: 1 addition & 1 deletion deploy/charts/imagepullsecrets/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ securityContext:
allowPrivilegeEscalation: false
image:
repository: ghcr.io/banzaicloud/imagepullsecrets
tag: v0.1.1
tag: v0.1.2
pullPolicy: IfNotPresent

imagePullSecrets: []
Expand Down
8 changes: 4 additions & 4 deletions static/charts/imagepullsecrets/chart.gogen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit e5fc942

Please sign in to comment.