-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(framework): include log level setup #20
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Diogo21Costa
force-pushed
the
fix/log_level
branch
2 times, most recently
from
January 31, 2024 15:06
445bb34
to
a8e626c
Compare
@miguelafsilva5 @ESCristiano: This PR depends on PR #18. As such, it should only be merged after approving the other one. |
ESCristiano
approved these changes
Feb 15, 2024
Signed-off-by: Diogo Costa <[email protected]>
Signed-off-by: Diogo Costa <[email protected]>
Signed-off-by: Diogo Costa <[email protected]>
Signed-off-by: Diogo Costa <[email protected]>
Signed-off-by: Diogo Costa <[email protected]>
Signed-off-by: Diogo Costa <[email protected]>
Signed-off-by: Diogo Costa <[email protected]>
Signed-off-by: Diogo Costa <[email protected]>
Signed-off-by: Diogo Costa <[email protected]>
Signed-off-by: Diogo Costa <[email protected]>
Signed-off-by: Diogo Costa <[email protected]>
Diogo21Costa
force-pushed
the
fix/log_level
branch
from
February 16, 2024 09:54
a8e626c
to
4aa9c66
Compare
miguelafsilva5
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This pull request introduces a new feature (echo mode), along with a crucial bug fix in the logging behavior of the Python framework.
Echo mode
The echo mode provides three options:
echo=full
): Prints all logging information.echo=none
): Suppresses printing of the entire log.echo=tf
): Prints only the log associated with the test framework.Log Level Fix
Additionally, this PR addresses a bug where the log level defined in the device tree was not being correctly passed to the
nix-build
command for the Python framework.Configuration in Device Tree Source (DTS)
To enable more granular control over the logging behavior, two fields are now used in the config.dts file:
log_level (
log_level=0, 1, 2
):echo (
echo=full, none, tf
):Please review the changes and share your thoughts and suggestions.