Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(framework): include log level setup #20

Merged
merged 11 commits into from
Feb 16, 2024
Merged

fix(framework): include log level setup #20

merged 11 commits into from
Feb 16, 2024

Conversation

Diogo21Costa
Copy link
Member

PR Summary

This pull request introduces a new feature (echo mode), along with a crucial bug fix in the logging behavior of the Python framework.

Echo mode

The echo mode provides three options:

  • Full echo (echo=full): Prints all logging information.
  • None echo (echo=none): Suppresses printing of the entire log.
  • Test Framework echo (echo=tf): Prints only the log associated with the test framework.

Log Level Fix

Additionally, this PR addresses a bug where the log level defined in the device tree was not being correctly passed to the nix-build command for the Python framework.

Configuration in Device Tree Source (DTS)

To enable more granular control over the logging behavior, two fields are now used in the config.dts file:

  1. log_level (log_level=0, 1, 2):

    • Defines the logging produced by the C code of the framework, and ranges from 0 (simplest) to 2 (most comprehensive).
  2. echo (echo=full, none, tf):

    • Determines the Echo mode behavior as described above.

Please review the changes and share your thoughts and suggestions.

src/inc/testf.h Outdated Show resolved Hide resolved
@Diogo21Costa Diogo21Costa force-pushed the fix/log_level branch 2 times, most recently from 445bb34 to a8e626c Compare January 31, 2024 15:06
@Diogo21Costa
Copy link
Member Author

@miguelafsilva5 @ESCristiano: This PR depends on PR #18. As such, it should only be merged after approving the other one.

@ESCristiano ESCristiano self-assigned this Feb 15, 2024
@ESCristiano ESCristiano self-requested a review February 15, 2024 19:04
@ESCristiano ESCristiano removed their assignment Feb 15, 2024
@miguelafsilva5 miguelafsilva5 merged commit 406a6e5 into main Feb 16, 2024
5 checks passed
@miguelafsilva5 miguelafsilva5 deleted the fix/log_level branch February 16, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants