Feature/abyss boreal colorscheme #50
Conversation
- adding functionality for NeoTree support - adding Aerial support - breaking down colors to be more granular for future setting
- NeoTree support (underline highlighting) - Aerial support (underline highlighting)
- adding palette setting for abyss-boreal - adding palette setting for original abyss - confirmed can swap between themese successfully!
- was using a copied version for simplified testing - replacing to original now that can swap between themes
- moved palette to its own file - added lualine color spec
- darkening the primary foreground - cleaning up unused colors - setting selection to the same darkred as abyss
- matching terminal colors from the mystic night theme
- adding some placeholders for screenshots of the original abyss and abyss-boreal themes - just placeholders since I don't have access to the same assets as the repo owner
- was too close to cursor color, couldn't tell where you were when on a parenthesis/bracket/curly-brace
|
@egotch Btw I've got a question, should the
If so, the colour makes difficult to read the code with soft colours. Edit: I don't know if the Cursorline colour was meant to look like this (Hex color: #282049):
If so, maybe you got confused following these comments
Those comments are outdated and actually they're not being used for what it says, that's my fault. The up-to-date comments are in |
egotch
force-pushed
the
feature/abyss-boreal-colorscheme
branch
from
c80dd3c to
61c1db3
Compare
Thanks for that and good catch there. I have the cursor line highlighting disabled on my vim setup, so didn't catch that. |
|
accidentally clicked close there |
don't worries 👍 |
|
All requested changes should now be in place |
|
@egotch All your changes works now. Talking about screenshots for abyss variants, could you take a screenshot to add it then in the readme? |
|
just tested that I could run both of those commands:
|
You bet. I'll get some good ones |
There was a problem hiding this comment.
Your changes works successfully, however, tests are still failing. That's because the properties of the specs has changed and are not actually included. That's something that I can do after merging the PR.
Another things I'm gonna do after merging the PR is:
- Refactor the palette test file
- Add the new spec properties in types.lua file and document them
- Apply the new properties into abyss palette
- Fix a non-PR related Vim bug
- Add the preview images (yours) for each abyss variant.
After doing all these things I'm gonna merge everything to main branch.
Meanwhile, you can continue adding more things that you consider are missing before merging. When everything is done, tell me to merge the PR. 👍
| dirtree = { | ||
| rootname = palette.white, | ||
| dirname = palette.darkteal, | ||
| curline = palette.cerulean, | ||
| }, |
There was a problem hiding this comment.
I've got a question, can these properties be used for any another file explorer-related plugin?
There was a problem hiding this comment.
Yea you can if you'd like to! I just set them for Neotree because it has that level of granularity on highlight groups
There was a problem hiding this comment.
Yea you can if you'd like to! I just set them for Neotree because it has that level of granularity on highlight groups. But no reason we couldn't use the same on the other file explorer extensions.
There was a problem hiding this comment.
I'll implement those properties in the highlight groups of other plugins like Neotree later
There was a problem hiding this comment.
@barrientosvctor
readme is updated with previews. After you merge, you'll need to update the urls of the preview images, otherwise they'll continue to point to my fork.
but you can preview it here:
https://github.com/egotch/abyss.nvim/tree/feature/abyss-boreal-colorscheme
looks pretty decent I'd say 😄
There was a problem hiding this comment.
@barrientosvctor readme is updated with previews. After you merge, you'll need to update the urls of the preview images, otherwise they'll continue to point to my fork.
Okay, I'll take care about that.
looks pretty decent I'd say 😄
They look amazing! Look so professional tbh.
When you consider everything is finished, tell me to merge the PR.
There was a problem hiding this comment.
I say we're ready, no additional changes from my end. MERGE!! 😎
#49
Abyss-Boreal theme variation
Color Palette
Cool tones inspired by the norther lights and the Minnesota North Woods.
Extensions
Documentation
I left some placeholders for the documentation. I don't have access to the assets on the main repo, so not sure how we want to handle that?? Let me know if you want me to get a screenshot on there.