add a fix for "undefined method `assets'" based on comments in #50 #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Having the same issue. Would love to see this merged |
|
Thanks @jipiboily I'll release a new version shortly |
|
Sorry I merged this too quickly and I reverted it here as I need to look into it more calmly: #60 I don't love the approach where the engine is in charge of writing these files on the fly. I am not sure what the right approach is here but there must be a cleaner path to solve this. |
|
Got it! Is there a new issue or PR to watch for news about this? I want to update our Gemfile when it gets released :) |
|
@jipiboily he reopened the old issue: #50 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This incorporates the patches suggested in #50 as-is.
I'd rather have this in the gem than use our fork, especially in the medium to long term.