Support API-only apps and other apps not using Sprockets or Propshaft #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And move to propshaft from sprockets.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
rosa
force-pushed
the
importmaps-and-api-mode
branch
from
4f1e0cc to
7a22f3f
Compare
rosa
force-pushed
the
importmaps-and-api-mode
branch
from
7a22f3f to
a231835
Compare
This was working before because we hadn't been requiring `turbo-rails` in the engine, but now that we require it, it results in a "Content missing" error as the response from Sessions#show doesn't include a matching turbo-frame ID.
jorgemanrubia
approved these changes
Nov 14, 2024
|
I'll release a new version later today with this 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same approach taken on rails/mission_control-jobs#203, also moving to
importmapsfor JavaScript. The approach requires apps to set up either Sprockets or Propshaft, and we recommend the latter as it's simpler and the default in Rails now.I also took the chance to refresh the dev environment a bit and update some dependencies.
This approach is a possible fix for #50.