Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ACME HTTP-01 Challenge support #29

Closed
wants to merge 1 commit into from

Conversation

elct9620
Copy link

For #26, make the HTTP-01 challenge supported.

TBD

  • Should we make the HTTP-01 optional (disabled by default)
  • Should we create HTTP-01 middleware when path start with /.well-known/acme-challenge/ or create it for all request
  • Let's try to make a mock ACME server to test it

@kevinmcconnell
Copy link
Collaborator

@elct9620 I actually had a different implementation of this prepared, which I've now shipped.

Sorry for the overlap in our work here -- I would have had mine merged sooner, but was travelling over the weekend. But thanks for your contribution all the same!

@elct9620 elct9620 deleted the feat/with-http01-challenge branch September 30, 2024 10:30
@elct9620
Copy link
Author

@kevinmcconnell

Thanks for your information. I checked the change and it is a better one. I
didn't check Service has a createMiddleware() method so that we can create a handler directly inside it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants