Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure to start wrapped process should not panic #23

Merged
merged 1 commit into from
May 1, 2024

Conversation

kevinmcconnell
Copy link
Collaborator

If we're unable to execute the wrapped process, we should log and error and return a non-zero exit code. However, previously we were triggering a panic in this case, which was unnecessary and alarming.

Fixes #22.

If we're unable to execute the wrapped process, we should log and error
and return a non-zero exit code. However, previously we were triggering
a `panic` in this case, which was unnecessary and alarming.
@kevinmcconnell kevinmcconnell merged commit 2cfbe2c into main May 1, 2024
1 check passed
@kevinmcconnell kevinmcconnell deleted the dont-panic-if-unable-to-launch-process branch May 1, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failure to launch wrapped process should be an error, not a panic
1 participant