-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add .gitignore to lintFiles #39
Conversation
What kind of files show up in a general |
@M-Zuber agreed, a lot of the files in a It's also weird to suggest that some files are required in a |
I am sorry, but I didn't understand your second point. {
name: 'language name',
files: {
...
},
gitignore: {
...
}
} and then in the linter it would perform the same task as the file linter (for example)? |
@M-Zuber my explanation was quite poor, but yes exactly like you explained! |
I've created an issue for a cleaner discussion. #41 |
NOTE: Comment is relevant to #41, moved there.
Yes, just like that!
Good point. However, as @jonfinerty pointed out offline:
So e.g., you have So to summarise, I think a global list of files to be expected in In the end, the role of the Great discussion, guys! Loving this progress, thanks for helping out :) |
@basicallydan you are completely right! Would be awesome to add these suggestions, guess we can track it in #41 from here on out. |
@matiassingers Cool, yes! I'll move my comment over there. In the meantime, can you do one small thing for this PR before I merge please? Just add a test or two to make sure that the |
@basicallydan yes of course, totally forgot about the test spec. Tried to keep the current format of the test spec, let me know if anything else needs fixing. |
@matiassingers No, that's fine :) Looks great. I'll merge and version later on. Thanks! |
First step is to check for a
.gitignore
file in the repo.As @basicallydan suggested in PR #38, perhaps a linter for common error files like:
.DS_Store
.Trashes
.Spotlight-V100
.idea
*.sublime-*
What do you think of adding a lintIgnore or something like that?