Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow a custom_load function #167

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Allow a custom_load function #167

wants to merge 1 commit into from

Conversation

basnijholt
Copy link
Owner

No description provided.

@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Merging #167 (e826bd6) into main (c31073c) will decrease coverage by 0.08%.
The diff coverage is 41.66%.

@@            Coverage Diff             @@
##             main     #167      +/-   ##
==========================================
- Coverage   72.63%   72.55%   -0.08%     
==========================================
  Files          22       22              
  Lines        2470     2485      +15     
==========================================
+ Hits         1794     1803       +9     
- Misses        676      682       +6     
Impacted Files Coverage Δ
adaptive_scheduler/_server_support/launcher.py 48.19% <16.66%> (-1.81%) ⬇️
adaptive_scheduler/_server_support/job_manager.py 94.79% <50.00%> (-1.95%) ⬇️
adaptive_scheduler/_server_support/run_manager.py 80.19% <100.00%> (+0.09%) ⬆️

... and 5 files with indirect coverage changes

with suppress(Exception):
learner.load(fname)
if args.custom_load is not None:
custom_load(learner, fname)

Check failure

Code scanning / CodeQL

Potentially uninitialized local variable

Local variable 'custom_load' may be used before it is initialized.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant