Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MAME config for apple2p, apple2e, apple2ee #13058

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tsankuanglee
Copy link

@tsankuanglee tsankuanglee commented Dec 9, 2024

This PR fixes the following problems, which were discovered when trying to use libretro MAME for apple2+/e/ee.

  1. For apple2+/e/ee, only add the SD/IDE card when a hard drive image is provided.
  2. Many paths are not quoted; when there are special characters or spaces in the path/filenames, the produced CMD file will cause parsing problem.
  3. Some path variables were set within if statements and unbound outside.
  4. Adding pluginpath, homepath, samplepath causes parsing problems as well. Not sure whether this is retroarch or MAME's parsing problem, but as a workaround, these are omit for now.

* only add SD/IDE card when an hard drive image is provided
* do not add pluginpath, homepath, samplepath for apple2p/e/ee to
  prevent errors
@tsankuanglee tsankuanglee marked this pull request as draft December 9, 2024 10:17
@tsankuanglee tsankuanglee marked this pull request as ready for review December 9, 2024 10:53
@Tovarichtch Tovarichtch added the 42 label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants