feat(wifaqul ulama): support wifaqul ulama uk prayer times #164
Conversation
Add new HighLatitudeFajrRule for Aqrabul Ayyam during High Latitude Perpetual Twilight.
Adds a new Calculation Method used by Wifaqul Ulama UK
…lculation Add specification of Fajr Angle for Aqrabul Youm Calculation
Dhuhr Adjustment should be 4 minutes.
Update METHODS.md
Add some Unit Tests
Don't invoke Aqrabul Youm resolver unless in perpetual twilight
Fix failing tests
Fix failing tests
Optimise TimeComponents.utcDate function to reduce line count in PrayerTimes.ts
Removes redundant variable
Fix failures with Linter on Unit Tests.
|
Jazakallah khair for this addition to the library. I would request if you could put together a json file of prayer times published by this group to be included in our testing repo (https://github.com/batoulapps/adhan-js/tree/master/Shared/Times) so we can see if there is a difference in the times being calculated by the library and the official published times. Please take a look at https://github.com/batoulapps/adhan-js/blob/master/Shared/Times/London-MoonsightingCommittee.json as an example. In it I have a copy of the original times and show where we had to adjust the times to account for rounding. It should be sufficient to include one day of prayer times for each month so we have a representative sample for the year. Also, it seems that the formatting of the README was changed significantly, this is making it difficult to see what was changed. If you could revert those changes and only have the new lines added that would be much better inshAllah. |
…le of the night Wifaqul Ulama's criteria allows for Middle of the Night for Fajr but 1/7th for Isha
… high latitude rule
|
@z3bi I've updated this PR with requested changes. |
This Pull Request adds support for Wifaqul Ulama UK's calculation criteria
It notably includes the following key changes: