refactor(workspace-tree): Future proof icon path resolution #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwahbong
requested review from
coeuvre,
jfirebaugh,
cameron-martin and
vogelsgesang
as code owners
cwahbong
force-pushed
the
extension-resource-path-fix
branch
from
7aa2938 to
7ee6502
Compare
|
This fixes the icon issues happened in #421. |
cwahbong
force-pushed
the
extension-resource-path-fix
branch
from
7ee6502 to
70d494d
Compare
…ied pakcage Current resource path resolution is using the source file as the base directory, this would fail if we minify the package into single js. Use extension path as the base directory is more reliable: it is also working for the current packaging, and we just have to make sure the resource layout of the minified package remains the same. An enum is provided with a test looping through all value and checking the existance of the icon files in extension.
cwahbong
force-pushed
the
extension-resource-path-fix
branch
from
70d494d to
e3a38f7
Compare
vogelsgesang
approved these changes
Oct 24, 2024
vogelsgesang
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current resource path resolution is using the source file as the base directory, this would fail if we minify the package into single js.
Use extension path as the base directory is more reliable: it is also working for the current packaging, and we just have to make sure the resource layout of the minified package remains the same.
An enum is provided with a test looping through all value and checking the existence of the icon files in extension.