Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[email protected] #3482

Merged

Conversation

publish-to-bcr-bot[bot]
Copy link
Contributor

@bazel-io
Copy link
Member

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (rules_venv) have been updated in this PR. Please review the changes.

@sputt
Copy link
Contributor

sputt commented Dec 28, 2024

This is ready to go. After this is in we can build on it with a full suite of Python lint and test aspects that create Python virtualenvs inside of actions.

@fmeum fmeum added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label Dec 29, 2024
fmeum
fmeum previously approved these changes Dec 29, 2024
@fmeum
Copy link
Contributor

fmeum commented Dec 29, 2024

CI is red

@bazel-io bazel-io dismissed fmeum’s stale review December 30, 2024 06:51

Require module maintainers' approval for newly pushed changes.

@meteorcloudy meteorcloudy merged commit 892216c into bazelbuild:main Jan 2, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants