Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add iceoryx2 #3485

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

feat: add iceoryx2 #3485

wants to merge 9 commits into from

Conversation

wep21
Copy link
Contributor

@wep21 wep21 commented Dec 25, 2024

  • as title

@wep21
feat: add iceoryx2
28d55dc 
Signed-off-by: wep21 <[email protected]>
@bazel-io
Copy link
Member

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (iceoryx2) have been updated in this PR. Please review the changes.

@wep21
Copy link
Contributor Author

wep21 commented Dec 25, 2024

@bazel-io skip_check unstable_url

@bazel-io bazel-io added the skip-url-stability-check Skip the URL stability check for the PR label Dec 25, 2024
@wep21
Copy link
Contributor Author

wep21 commented Dec 25, 2024

@fmeum @meteorcloudy request review from bazel maintainers

@fmeum fmeum added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label Dec 25, 2024
fmeum
fmeum reviewed Dec 25, 2024
View reviewed changes
modules/iceoryx2/0.5.0/MODULE.bazel

crate = use_extension("@rules_rust//crate_universe:extensions.bzl", "crate")
crate.from_cargo(
name = "crate_index",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know too little about rules_rust to determine whether this is safe - what happens if some other module also specifies this name?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry, but I'm not sure. @dep_module//:crate_index and @root_module//:crate_index are confusing for bazel?
Is it safer to change name like iceoryx2_crate_index?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That depends on whether these libraries may end up getting linked together with user-supplied code. If so, versions need to align and you need to share a dependency closure. If not, a separate namespace is probably more efficient.

I don't know this extension or your use case well enough to make a call. I would suggest asking for advice in the #rust slack channel.

@wep21 wep21 force-pushed the add-iceoryx2 branch 3 times, most recently from 73f7180 to ef75a92 Compare December 26, 2024 00:55
@wep21
update
de9fd23 
Signed-off-by: wep21 <[email protected]>
@wep21 wep21 mentioned this pull request Dec 26, 2024
Open
17 tasks
wep21 added 4 commits December 27, 2024 00:22
@wep21
update iceoryx
6f38010 
Signed-off-by: wep21 <[email protected]>
@wep21
update iceoryx2
4e060b4 
Signed-off-by: wep21 <[email protected]>
@wep21
fix
c3548a9 
Signed-off-by: wep21 <[email protected]>
@wep21
fix
7b71201 
Signed-off-by: wep21 <[email protected]>
@wep21 wep21 force-pushed the add-iceoryx2 branch 2 times, most recently from 71bfe89 to 708b7b1 Compare December 26, 2024 17:24
@wep21
update
b7ff8d4 
Signed-off-by: wep21 <[email protected]>
@wep21 wep21 force-pushed the add-iceoryx2 branch 9 times, most recently from 7ed6574 to 8353136 Compare December 29, 2024 03:53
@wep21 wep21 force-pushed the add-iceoryx2 branch 2 times, most recently from 5e0e42c to 4ecb21b Compare December 29, 2024 04:22
@wep21
update
99fe91b 
Signed-off-by: wep21 <[email protected]>
@wep21
drop debian10
2104f1d 
Signed-off-by: wep21 <[email protected]>
@wep21 wep21 requested a review from fmeum December 29, 2024 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmeum fmeum Awaiting requested review from fmeum

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval skip-url-stability-check Skip the URL stability check for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wep21 @bazel-io @fmeum