fix: remove empty glob from geographiclib #3495
Conversation
wep21
commented
Dec 27, 2024
wep21
commented
- as title
Signed-off-by: wep21 <[email protected]>
|
@bazel-io skip_check unstable_url |
bazel-io
added
the
skip-url-stability-check
|
@fmeum @meteorcloudy please add presubmit auto run. |
fmeum
added
the
presubmit-auto-run
|
@fmeum The macos ci error seems to be irrelevant to this PR for me. How do you think about it? |
|
The failure persists. You could check with rules_foreign_cc whether this is a known issue. Maybe there is a way to have the ruleset use a hermetic Python provided by rules_python? That would also help users of your module that don't have Python installed locally. |
|
There are just a very small number of substitutions in this case in the Config.h file. You could consider just setting them manually in bzl and forgoing the python script that does the cmake parsing. |
Signed-off-by: wep21 <[email protected]>
Head branch was pushed to by a user without write access
bazel-io
dismissed stale reviews from fmeum and kgreenek
Require module maintainers' approval for newly pushed changes.
wep21
force-pushed
the
fix-empty-glob-geographiclib
branch
from
81a39a4 to
ea97bfc
Compare
|
@fmeum Setting default python version seems to solve the error, I'm not sure this is the proper python version though. |
bazel-io
dismissed stale reviews from fmeum and kgreenek
Require module maintainers' approval for newly pushed changes.
Signed-off-by: wep21 <[email protected]>
wep21
force-pushed
the
fix-empty-glob-geographiclib
branch
from
a9bf856 to
5cebdbd
Compare
There was a problem hiding this comment.
Great, I'll keep this helper module in mind while reviewing other contributions!
@meteorcloudy FYI
