Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add riegeli 0.0.0-20241218-3385e3c #3502

Merged
merged 3 commits into from
Dec 31, 2024
Merged

Add riegeli 0.0.0-20241218-3385e3c #3502

merged 3 commits into from
Dec 31, 2024

Conversation

dryman
Copy link
Contributor

@dryman dryman commented Dec 30, 2024

This version is required by ArrayRecord

Last PR attempt didn't work because I needed to add @bazel-io skip_check unstable_url in the PR comment.

@bazel-io skip_check unstable_url

This version is required by ArrayRecord
@dryman
Copy link
Contributor Author

dryman commented Dec 30, 2024

@bazel-io skip_check unstable_url

@bazel-io
Copy link
Member

Hello @QrczakMK, modules you maintain (riegeli) have been updated in this PR. Please review the changes.

@bazel-io bazel-io added the skip-url-stability-check Skip the URL stability check for the PR label Dec 30, 2024
fmeum
fmeum previously approved these changes Dec 30, 2024
Co-authored-by: Fabian Meumertzheim <[email protected]>
@bazel-io bazel-io dismissed fmeum’s stale review December 30, 2024 06:48

Require module maintainers' approval for newly pushed changes.

QrczakMK
QrczakMK previously approved these changes Dec 30, 2024
bazel-io
bazel-io previously approved these changes Dec 30, 2024
Copy link
Member

@bazel-io bazel-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @bazelbuild/bcr-maintainers, all modules in this PR have been approved by their maintainers. Please take a final look to merge this PR.

@fmeum fmeum enabled auto-merge (squash) December 30, 2024 09:41
@fmeum fmeum added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label Dec 30, 2024
Unfortunately riegeli doesn't build on 8.x.
auto-merge was automatically disabled December 30, 2024 23:42

Head branch was pushed to by a user without write access

@bazel-io bazel-io dismissed stale reviews from QrczakMK and themself December 30, 2024 23:42

Require module maintainers' approval for newly pushed changes.

@dryman
Copy link
Contributor Author

dryman commented Dec 31, 2024

@QrczakMK we need your approval again because I made a change to lock bazel to 7.x. (one of the upstream package lzma/xz doesn't build with 8.x)

@fmeum fmeum enabled auto-merge (squash) December 31, 2024 07:16
Copy link

@QrczakMK QrczakMK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great to fix lzma so that it builds with bazel 8.x.

Copy link
Member

@bazel-io bazel-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @bazelbuild/bcr-maintainers, all modules in this PR have been approved by their maintainers. Please take a final look to merge this PR.

@fmeum fmeum merged commit 9a5efb8 into bazelbuild:main Dec 31, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval skip-url-stability-check Skip the URL stability check for the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants