[email protected] - Add patch for incompatible_disallow_empty_glob #3507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (llvm-project) have been updated in this PR. Please review the changes. |
UebelAndre
force-pushed
the
main
branch
6 times, most recently
from
b938f14 to
67e7575
Compare
UebelAndre
changed the title
UebelAndre
changed the title
UebelAndre
changed the title
fmeum
reviewed
Dec 31, 2024
fmeum
added
the
presubmit-auto-run
|
@fmeum updated! |
fmeum
previously approved these changes
Dec 31, 2024
fmeum
reviewed
Dec 31, 2024
modules/llvm-project/17.0.3.bcr.1/patches/0003-Add-MODULE.bazel.patch
Outdated
Show resolved
Hide resolved
bazel-io
dismissed
fmeum’s stale review
Require module maintainers' approval for newly pushed changes.
Co-authored-by: Fabian Meumertzheim <[email protected]>
fmeum
reviewed
Dec 31, 2024
fmeum
approved these changes
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An issue was reported in
rules_rust(bazelbuild/rules_rust#3137) where some local patches to satisfy bazelbuild/bazel#8195 were added to llvm via asingle_version_overridewhich does not affect consumers. This change is an attempt to upstream an otherwise noop change to llvm that supports this flag being flipped in Bazel.