chore: add container runtime to Java example #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demonstrates how to move away from deprecated java_image in rules_docker
alexeagle
force-pushed
the
java_oci
branch
5 times, most recently
from
c33a498 to
972e503
Compare
alexeagle
commented
Oct 10, 2023
|
Ping @jin |
|
ping @gregestren |
|
Who is an appropriate domain expert to look at this? I'm not immediately familiar with this. I'm more than happy to approve any domain-expert-reviewed PR if needed but I need some help, especially across the entire examples repo. |
meisterT
reviewed
Oct 17, 2023
meisterT
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Examples of using Docker (or alternative container runtimes) are probably best layered next to existing applications, since it's not a language-specific ruleset.