fix(qsync): IJ incorrectly recognizes files as external and asks to a… #6964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dd them the the PV fixes bazelbuild#6963
github-actions
bot
added
the
awaiting-review
LeFrosch
approved these changes
Nov 5, 2024
github-actions
bot
removed
the
awaiting-review
mai93
reviewed
Nov 19, 2024
| @@ -172,7 +172,9 @@ public boolean isExcluded(Path workspacePath) { | |||
| */ | |||
| public Optional<Path> getIncludingContentRoot(Path workspacePath) { | |||
| Optional<Path> contentRoot = | |||
| projectIncludes().stream().filter(workspacePath::startsWith).findAny(); | |||
| projectIncludes().stream() | |||
| .filter(projectInclude -> projectInclude.toString().isEmpty() || workspacePath.startsWith(projectInclude)) | |||
There was a problem hiding this comment.
@tpasternak what if the file is really outside the workspace, this means that if directories: . is used no file will get the "Add file to project" action?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…dd them the the PV
fixes #6963
Checklist
Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.
Discussion thread for this change
Issue number:
<please reference the issue number or url here>Description of this change