Stop adding a trailing # when filtering tests for JUnit 5 #7060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
product: IntelliJ
|
wow, great finding! |
joca-bt
force-pushed
the
master
branch
2 times, most recently
from
e333007
to
a24c610
Compare
|
Updated the failing tests. |
The JUnit 5 selector for methods does not support a trailing #. This is easy to verify: ``` > java -jar junit-platform-console-standalone-<version>.jar execute -cp <my tests jar> --select-class=<my test class> ``` will work, while ``` > java -jar junit-platform-console-standalone-<version>.jar execute -cp <my tests jar> --select-class=<my test class># ``` will fail. This will change `--test_filter`'s value from `<my test class>#` to `<my test class>` when filtering for classes. The new value requires no postprocessing and is directly compatible with JUnit's selector "language". The trailing # was introduced in #4473. This undocumented breaking change created issues for our own test runner.
tpasternak
approved these changes
Nov 27, 2024
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JUnit 5 selector for methods does not support a trailing #.
This is easy to verify:
will work, while
will fail.
This will change
--test_filter's value from<my test class>#to<my test class>when filtering for classes. The new value requires no postprocessing and is directly compatible with JUnit's selector "language".The trailing # was introduced in #4473. This undocumented breaking change created issues for our own test runner.
Checklist
Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.
Discussion thread for this change
Issue number: #7061
Description of this change