Adds support for the google test run button in nova #7062
+219
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeFrosch
force-pushed
the
radler-google-test
branch
4 times, most recently
from
45b03a5
to
1d2e136
Compare
LeFrosch
force-pushed
the
radler-google-test
branch
from
1d2e136
to
e09796f
Compare
Replaced generic 'clwb/...' target with specific 'clwb:clwb_bazel_zip' and ':clwb_tests' in all build configurations. This ensures only compatible targets are build.
ujohnny
requested changes
Nov 26, 2024
| @@ -59,6 +59,8 @@ java_import( | |||
| "plugins/clion-test-google/lib/*.jar", | |||
| "plugins/clion-test-catch/lib/*.jar", | |||
| "plugins/clion-test-boost/lib/*.jar", | |||
| "plugins/clion-radler/lib/*.jar", | |||
There was a problem hiding this comment.
a possible solution: define this in a separate java_import statement, use that library in https://github.com/bazelbuild/intellij/pull/7062/files#diff-242eb0d3dc78241907aa160705183dba65b9f3cb747ee146887eaf081f7622f5R18 and let's keep using classic so far for development purposes
There was a problem hiding this comment.
I played around with multiple options, I think just using the suppressed plugin set options is the easiest for now. This allows us later to run test for classic and radler. Tho radler requires the path to the backend binary which I could not get working for now.
LeFrosch
requested review from
mai93,
tpasternak and
agluszak
as code owners
github-actions
bot
added
product: CLion
This was
linked to
issues
Nov 27, 2024
ujohnny
requested changes
Nov 29, 2024
LeFrosch
force-pushed
the
radler-google-test
branch
from
01023c5
to
8fb48e6
Compare
LeFrosch
force-pushed
the
radler-google-test
branch
from
8fb48e6
to
3f604ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion thread for this change
Issue number: #6981 and #7043
Description of this change
Adds support for the gutter run button for google tests. The button itself is provided by the backend and we only need to register a provider to actually run these tests.