Skip to content

Commit

Permalink
Stop suggesting that Java's exported_plugins is transitive. (#1236)
Browse files Browse the repository at this point in the history
  • Loading branch information
cpovirk authored Nov 16, 2024
1 parent c93d6ae commit 87d5987
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions docs/kotlin.md
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ kt_jvm_import(
| :------------- | :------------- | :------------- | :------------- | :------------- |
| <a id="kt_jvm_import-name"></a>name | A unique name for this target. | <a href="https://bazel.build/concepts/labels#target-names">Name</a> | required | |
| <a id="kt_jvm_import-deps"></a>deps | Compile and runtime dependencies | <a href="https://bazel.build/concepts/labels">List of labels</a> | optional | `[]` |
| <a id="kt_jvm_import-exported_compiler_plugins"></a>exported_compiler_plugins | Exported compiler plugins.<br><br>Compiler plugins listed here will be treated as if they were added in the plugins attribute of any targets that directly depend on this target. Unlike java_plugins' exported_plugins, this is not transitive | <a href="https://bazel.build/concepts/labels">List of labels</a> | optional | `[]` |
| <a id="kt_jvm_import-exported_compiler_plugins"></a>exported_compiler_plugins | Exported compiler plugins.<br><br>Compiler plugins listed here will be treated as if they were added in the plugins attribute of any targets that directly depend on this target. Like java_plugins' exported_plugins, this is not transitive | <a href="https://bazel.build/concepts/labels">List of labels</a> | optional | `[]` |
| <a id="kt_jvm_import-exports"></a>exports | Exported libraries.<br><br>Deps listed here will be made available to other rules, as if the parents explicitly depended on these deps. This is not true for regular (non-exported) deps. | <a href="https://bazel.build/concepts/labels">List of labels</a> | optional | `[]` |
| <a id="kt_jvm_import-jar"></a>jar | The jar listed here is equivalent to an export attribute. | <a href="https://bazel.build/concepts/labels">Label</a> | optional | `None` |
| <a id="kt_jvm_import-jars"></a>jars | The jars listed here are equavalent to an export attribute. The label should be either to a single class jar, or one or more filegroup labels. The filegroups, when resolved, must contain only one jar containing classes, and (optionally) one peer file containing sources, named `<jarname>-sources.jar`.<br><br>DEPRECATED - please use `jar` and `srcjar` attributes. | <a href="https://bazel.build/concepts/labels">List of labels</a> | optional | `[]` |
Expand Down Expand Up @@ -153,7 +153,7 @@ This rule compiles and links Kotlin and Java sources into a .jar file.
| <a id="kt_jvm_library-data"></a>data | The list of files needed by this rule at runtime. See general comments about `data` at [Attributes common to all build rules](https://docs.bazel.build/versions/master/be/common-definitions.html#common-attributes). | <a href="https://bazel.build/concepts/labels">List of labels</a> | optional | `[]` |
| <a id="kt_jvm_library-resources"></a>resources | A list of files that should be include in a Java jar. | <a href="https://bazel.build/concepts/labels">List of labels</a> | optional | `[]` |
| <a id="kt_jvm_library-associates"></a>associates | Kotlin deps who should be considered part of the same module/compilation-unit for the purposes of "internal" access. Such deps must all share the same module space and so a target cannot associate to two deps from two different modules. | <a href="https://bazel.build/concepts/labels">List of labels</a> | optional | `[]` |
| <a id="kt_jvm_library-exported_compiler_plugins"></a>exported_compiler_plugins | Exported compiler plugins.<br><br>Compiler plugins listed here will be treated as if they were added in the plugins attribute of any targets that directly depend on this target. Unlike `java_plugin`s exported_plugins, this is not transitive | <a href="https://bazel.build/concepts/labels">List of labels</a> | optional | `[]` |
| <a id="kt_jvm_library-exported_compiler_plugins"></a>exported_compiler_plugins | Exported compiler plugins.<br><br>Compiler plugins listed here will be treated as if they were added in the plugins attribute of any targets that directly depend on this target. Like `java_plugin`s exported_plugins, this is not transitive | <a href="https://bazel.build/concepts/labels">List of labels</a> | optional | `[]` |
| <a id="kt_jvm_library-exports"></a>exports | Exported libraries.<br><br>Deps listed here will be made available to other rules, as if the parents explicitly depended on these deps. This is not true for regular (non-exported) deps. | <a href="https://bazel.build/concepts/labels">List of labels</a> | optional | `[]` |
| <a id="kt_jvm_library-javac_opts"></a>javac_opts | Javac options to be used when compiling this target. These opts if provided will be used instead of the ones provided to the toolchain. | <a href="https://bazel.build/concepts/labels">Label</a> | optional | `None` |
| <a id="kt_jvm_library-kotlinc_opts"></a>kotlinc_opts | Kotlinc options to be used when compiling this target. These opts if provided will be used instead of the ones provided to the toolchain. | <a href="https://bazel.build/concepts/labels">Label</a> | optional | `None` |
Expand Down
4 changes: 2 additions & 2 deletions kotlin/internal/jvm/jvm.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,7 @@ these deps. This is not true for regular (non-exported) deps.""",
Exported compiler plugins.
Compiler plugins listed here will be treated as if they were added in the plugins attribute
of any targets that directly depend on this target. Unlike `java_plugin`s exported_plugins,
of any targets that directly depend on this target. Like `java_plugin`s exported_plugins,
this is not transitive""",
default = [],
providers = [[_KtCompilerPluginInfo], [KtPluginConfiguration]],
Expand Down Expand Up @@ -465,7 +465,7 @@ these deps. This is not true for regular (non-exported) deps.""",
Exported compiler plugins.
Compiler plugins listed here will be treated as if they were added in the plugins
attribute of any targets that directly depend on this target. Unlike java_plugins'
attribute of any targets that directly depend on this target. Like java_plugins'
exported_plugins, this is not transitive""",
default = [],
providers = [[_KtCompilerPluginInfo], [KtPluginConfiguration], [_KspPluginInfo]],
Expand Down

0 comments on commit 87d5987

Please sign in to comment.