Skip to content

Commit

Permalink
Fix BCR presubmit pipeline (#3082)
Browse files Browse the repository at this point in the history
Hopefully this resolves the following:
https://buildkite.com/bazel/bcr-presubmit/builds/9302#0193b38a-65b5-4be1-91b6-138d4ab9cc90
```
ERROR: The test module directory does not exist in the source archive: /Users/buildkite/builds/bk-macos-arm64-0n05/bazel-org-repo-root/output/extensions/bindgen/extensions/bindgen
Traceback (most recent call last):
  File "/Users/buildkite/builds/bk-macos-arm64-0n05/bazel/bcr-presubmit/bcr_presubmit.py", line 537, in <module>
    sys.exit(main())
             ^^^^^^
  File "/Users/buildkite/builds/bk-macos-arm64-0n05/bazel/bcr-presubmit/bcr_presubmit.py", line 528, in main
    repo_location, config_file = prepare_test_module_repo(args.module_name, args.module_version, args.overwrite_bazel_version)
                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/buildkite/builds/bk-macos-arm64-0n05/bazel/bcr-presubmit/bcr_presubmit.py", line 269, in prepare_test_module_repo
    error("The test module directory does not exist in the source archive: %s" % test_module_root)
  File "/Users/buildkite/builds/bk-macos-arm64-0n05/bazel/bcr-presubmit/bcr_presubmit.py", line 58, in error
    raise BcrPipelineException("BCR Presubmit failed!")
BcrPipelineException: BCR Presubmit failed!
🚨 Error: The command exited with status 1
^^^ +++
```

My assumption is that `module_path` is an extension of where the
presubmit yaml exists relative to the root one. So this should finally
enable CI to run in th eright place with the correct dependency.
  • Loading branch information
UebelAndre authored Dec 11, 2024
1 parent 473caac commit c77ab04
Show file tree
Hide file tree
Showing 10 changed files with 14 additions and 14 deletions.
2 changes: 1 addition & 1 deletion .bcr/extensions/bindgen/presubmit.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
bcr_test_module:
module_path: "extensions/bindgen"
module_path: ""
matrix:
platform: ["macos_arm64", "ubuntu2004", "windows"]
bazel: ["7.x"]
Expand Down
2 changes: 1 addition & 1 deletion .bcr/extensions/prost/presubmit.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
bcr_test_module:
module_path: "extensions/prost"
module_path: ""
matrix:
platform: ["macos_arm64", "ubuntu2004", "windows"]
bazel: ["7.x"]
Expand Down
2 changes: 1 addition & 1 deletion .bcr/extensions/protobuf/presubmit.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
bcr_test_module:
module_path: "extensions/protobuf"
module_path: ""
matrix:
platform: ["macos_arm64", "ubuntu2004", "windows"]
bazel: ["7.x"]
Expand Down
2 changes: 1 addition & 1 deletion .bcr/extensions/wasm_bindgen/presubmit.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
bcr_test_module:
module_path: "extensions/wasm_bindgen"
module_path: ""
matrix:
platform: ["macos_arm64", "ubuntu2004", "windows"]
bazel: ["7.x"]
Expand Down
2 changes: 1 addition & 1 deletion MODULE.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

module(
name = "rules_rust",
version = "0.55.4",
version = "0.55.5",
)

###############################################################################
Expand Down
4 changes: 2 additions & 2 deletions extensions/bindgen/MODULE.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@

module(
name = "rules_rust_bindgen",
version = "0.55.4",
version = "0.55.5",
)

bazel_dep(
name = "rules_rust",
version = "0.55.4",
version = "0.55.5",
)
bazel_dep(
name = "bazel_skylib",
Expand Down
4 changes: 2 additions & 2 deletions extensions/prost/MODULE.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@

module(
name = "rules_rust_prost",
version = "0.55.4",
version = "0.55.5",
)

bazel_dep(
name = "rules_rust",
version = "0.55.4",
version = "0.55.5",
)
bazel_dep(
name = "platforms",
Expand Down
4 changes: 2 additions & 2 deletions extensions/protobuf/MODULE.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@

module(
name = "rules_rust_protobuf",
version = "0.55.4",
version = "0.55.5",
)

bazel_dep(
name = "rules_rust",
version = "0.55.4",
version = "0.55.5",
)
bazel_dep(
name = "bazel_skylib",
Expand Down
4 changes: 2 additions & 2 deletions extensions/wasm_bindgen/MODULE.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@

module(
name = "rules_rust_wasm_bindgen",
version = "0.55.4",
version = "0.55.5",
)

bazel_dep(
name = "rules_rust",
version = "0.55.4",
version = "0.55.5",
)
bazel_dep(
name = "bazel_skylib",
Expand Down
2 changes: 1 addition & 1 deletion version.bzl
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
"""The version of rules_rust."""

VERSION = "0.55.4"
VERSION = "0.55.5"

0 comments on commit c77ab04

Please sign in to comment.