Update wasm_bindgen to non-deprecated rules_js API #2934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UebelAndre
approved these changes
Oct 14, 2024
dzbarsky
force-pushed
the
zbarsky/js-info
branch
from
6e28f0e to
01fb19b
Compare
This means you have to use rules_js 2.x instead of 1.x with rules_rust. We can add it to release notes but I think it's unlikely anyone cares, I suspect I might be the only one using this given I keep finding it broken :) |
dzbarsky
force-pushed
the
zbarsky/js-info
branch
from
01fb19b to
9afcf48
Compare
dzbarsky
force-pushed
the
zbarsky/js-info
branch
from
5a158d5 to
102dfc9
Compare
|
@UebelAndre I think CI is "green", I retried twice and got different flakes every time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
js_infoneeds to jump through some hoops to support the legacy names. The new ones are shorter and clearer.Also, set the toolchain on the action to support Auto Exec Groups while I'm here.