Moved rust extension rules into a separate workspaces. #3007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UebelAndre
force-pushed
the
bzlmod
branch
5 times, most recently
from
6820db7 to
dc90468
Compare
UebelAndre
force-pushed
the
bzlmod
branch
24 times, most recently
from
08678f2 to
f8a6bf3
Compare
I've created bazelbuild/continuous-integration#2120 as a hopeful path forward. |
|
presubmit is now working https://buildkite.com/bazel/rules-rust-rustlang/builds/12752 |
UebelAndre
force-pushed
the
bzlmod
branch
6 times, most recently
from
dc7be3a to
21ceb8b
Compare
With this in place I'll go ahead and update the PR to reflect the granular workspaces change instead of |
UebelAndre
force-pushed
the
bzlmod
branch
5 times, most recently
from
5f993e7 to
d78aaab
Compare
UebelAndre
changed the title
rules_rust_ext workspace.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 6, 2024
This was a miss from #3007
UebelAndre
commented
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change moves the
bindgen,proto, andwasm_bindgensub-packages into individual workspaces within theextensionsdirectory. The intent is improve ease of maintenance of both core and extension Rust rules by ensuring changes to extensions have no impact on the core rules. Core rules should never depend on extensions.Load statements should be updated according to the following table:
@rules_rust//bindgen@rules_rust_bindgen//@rules_rust//proto/prost@rules_rust_prost//@rules_rust//proto/protobuf@rules_rust_protobuf//@rules_rust//wasm_bindgen@rules_rust_wasm_bindgen//closes #2882