cargo: Allow disabling the default_shell_env
for build scripts
#3020
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new boolean attribute to
cargo_build_script
rules calleduse_default_shell_env
which is set toTrue
by default.The goal here is to make Cargo Build Scripts more hermetic. If you set
use_default_shell_env
to false, local environment variables likePATH
should not get set for build scripts, preventing them from relying on tools not provided by Bazel.Note: I considered adding a global
use_default_shell_env_for_cargo_build_scripts
setting, but couldn't figure out a good way to make the global setting work with this attribute. e.g. if you disableuse_default_shell_env
globally, ideally you still have a way to enable it for an individual crate, but I couldn't figure out how to set the defaults for the global setting and this local attr to get that to workRelated to #2665