Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix release workflow on macos #3049

Merged
merged 3 commits into from
Dec 5, 2024
Merged

Fix release workflow on macos #3049

merged 3 commits into from
Dec 5, 2024

Conversation

UebelAndre
Copy link
Collaborator

@UebelAndre UebelAndre commented Dec 5, 2024 •
edited
Loading

This avoids the following error


The macOS-12 environment is deprecated, consider switching to macOS-13, macOS-14 (macos-latest) or macOS-15. For more details, see https://github.com/actions/runner-images/issues/10721

@UebelAndre UebelAndre marked this pull request as ready for review December 5, 2024 17:36
@UebelAndre UebelAndre enabled auto-merge December 5, 2024 17:37
illicitonion
illicitonion approved these changes Dec 5, 2024
View reviewed changes
Copy link
Collaborator

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fun!

@UebelAndre UebelAndre added this pull request to the merge queue Dec 5, 2024
@illicitonion illicitonion removed this pull request from the merge queue due to a manual request Dec 5, 2024
illicitonion
illicitonion reviewed Dec 5, 2024
View reviewed changes
Copy link
Collaborator

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, we probably want to bump to 13 for maximum compatibility of our produced artifacts?

@UebelAndre
Copy link
Collaborator Author

Actually, we probably want to bump to 13 for maximum compatibility of our produced artifacts?

Updated!

@UebelAndre UebelAndre enabled auto-merge December 5, 2024 17:43
@UebelAndre UebelAndre disabled auto-merge December 5, 2024 17:47
@UebelAndre UebelAndre enabled auto-merge December 5, 2024 17:53
@UebelAndre UebelAndre added this pull request to the merge queue Dec 5, 2024
Merged via the queue into bazelbuild:main with commit adea1d5 Dec 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illicitonion illicitonion illicitonion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@UebelAndre @illicitonion