Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Run CI without building runfiles links" #3054

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

UebelAndre
Copy link
Collaborator

@UebelAndre UebelAndre commented Dec 6, 2024

Reverts #2340

It seems like there were cache hits that dodged an important issue

bazel coverage //…
================================================================================
FAIL: //test/unit/crate_name:default/crate-name-test (see /private/var/tmp/_bazel_user/76282c66b0dfe3c5cb9a230bdc913a52/execroot/_main/bazel-out/darwin_arm64-fastbuild/testlogs/test/unit/crate_name/default/crate-name-test/test.log)
INFO: From Testing //test/unit/crate_name:default/crate-name-test:
==================== Test output for //test/unit/crate_name:default/crate-name-test:

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

/private/var/tmp/_bazel_user/76282c66b0dfe3c5cb9a230bdc913a52/sandbox/darwin-sandbox/3262/execroot/_main/bazel-out/darwin_arm64-opt-exec-ST-d57f47055a04/bin/external/bazel_tools~remote_coverage_tools_extension~remote_coverage_tools/Main: Cannot locate runfiles directory. (Set $JAVA_RUNFILES to inhibit searching.)

This flag still cannot be flipped without breaking coverage it seems.

@UebelAndre UebelAndre marked this pull request as ready for review December 6, 2024 03:28
@UebelAndre UebelAndre enabled auto-merge December 6, 2024 03:28
@UebelAndre
Copy link
Collaborator Author

This was originally noticed on #3052 where the updated test //test/bzl_version:bzl_version_test failed.
https://buildkite.com/bazel/rules-rust-rustlang/builds/13085#019399fb-3319-4b50-b03e-c23ef1c3e8f4

Unfortunately, due to bazelbuild/continuous-integration#1838 no logs were captured but the issue is reproducible locally

~/Code/rules_rust (bzlmod ✔) bazel coverage //test/bzl_version:bzl_version_test
INFO: Using default value for --instrumentation_filter: "^//test/bzl_version[/:]".
INFO: Override the above default with --instrumentation_filter
INFO: Analyzed target //test/bzl_version:bzl_version_test (98 packages loaded, 4238 targets configured).
FAIL: //test/bzl_version:bzl_version_test (see /private/var/tmp/_bazel_user/76282c66b0dfe3c5cb9a230bdc913a52/execroot/_main/bazel-out/darwin_arm64-fastbuild/testlogs/test/bzl_version/bzl_version_test/test.log)
INFO: From Testing //test/bzl_version:bzl_version_test:
==================== Test output for //test/bzl_version:bzl_version_test:

running 1 test
test module_bzl_has_correct_version ... ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

/private/var/tmp/_bazel_user/76282c66b0dfe3c5cb9a230bdc913a52/sandbox/darwin-sandbox/4937/execroot/_main/bazel-out/darwin_arm64-opt-exec-ST-d57f47055a04/bin/external/bazel_tools~remote_coverage_tools_extension~remote_coverage_tools/Main: Cannot locate runfiles directory. (Set $JAVA_RUNFILES to inhibit searching.)
================================================================================
INFO: LCOV coverage report is located at /private/var/tmp/_bazel_user/76282c66b0dfe3c5cb9a230bdc913a52/execroot/_main/bazel-out/_coverage/_coverage_report.dat
 and execpath is bazel-out/_coverage/_coverage_report.dat
INFO: From Coverage report generation:
Dec 05, 2024 8:28:29 PM com.google.devtools.coverageoutputgenerator.Main getTracefiles
INFO: Found 1 tracefiles.
Dec 05, 2024 8:28:29 PM com.google.devtools.coverageoutputgenerator.Main parseFilesSequentially
INFO: Parsing file bazel-out/darwin_arm64-fastbuild/testlogs/test/bzl_version/bzl_version_test/coverage.dat
Dec 05, 2024 8:28:29 PM com.google.devtools.coverageoutputgenerator.Main getGcovInfoFiles
INFO: No gcov info file found.
Dec 05, 2024 8:28:29 PM com.google.devtools.coverageoutputgenerator.Main getGcovJsonInfoFiles
INFO: No gcov json file found.
Dec 05, 2024 8:28:29 PM com.google.devtools.coverageoutputgenerator.Main getProfdataFileOrNull
INFO: No .profdata file found.
Dec 05, 2024 8:28:29 PM com.google.devtools.coverageoutputgenerator.Main runWithArgs
WARNING: There was no coverage found.
INFO: Found 1 test target...
Target //test/bzl_version:bzl_version_test up-to-date:
  bazel-bin/test/bzl_version/test-1333522163/bzl_version_test
INFO: Elapsed time: 8.936s, Critical Path: 2.47s
INFO: 108 processes: 97 internal, 10 darwin-sandbox, 1 worker.
INFO: Build completed, 1 test FAILED, 108 total actions
//test/bzl_version:bzl_version_test                                      FAILED in 0.5s
  /private/var/tmp/_bazel_user/76282c66b0dfe3c5cb9a230bdc913a52/execroot/_main/bazel-out/darwin_arm64-fastbuild/testlogs/test/bzl_version/bzl_version_test/test.log

Executed 1 out of 1 test: 1 fails locally.

@UebelAndre UebelAndre added this pull request to the merge queue Dec 6, 2024
Merged via the queue into main with commit 405a8a6 Dec 6, 2024
7 checks passed
@UebelAndre UebelAndre deleted the revert-2340-norunfiles branch December 6, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants