Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove crosstool files #3118

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Conversation

katre
Copy link
Member

@katre katre commented Dec 17, 2024

Remove toolchain.crosstool_files and _cc_toolchains.
Fixes #3115.

@katre katre force-pushed the remove_crosstool_files branch from e5bea01 to 0a2c351 Compare December 17, 2024 21:21
@katre katre changed the title [WIP] Remove crosstool files Remove crosstool files Dec 17, 2024
@katre katre requested a review from illicitonion December 17, 2024 21:27
@katre katre marked this pull request as ready for review December 17, 2024 21:27
@UebelAndre UebelAndre added this pull request to the merge queue Dec 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Dec 17, 2024
@katre
Copy link
Member Author

katre commented Dec 17, 2024

Does this need re-approval? I don't actually understand how github's merge queue works.

@UebelAndre
Copy link
Collaborator

Does this need re-approval? I don't actually understand how github's merge queue works.

The merge queue will rebase and run CI again. However, BazelCI is flaky so pull-requests end up not getting merged. Very frustrating 😞

I'll queue it again.

@UebelAndre UebelAndre added this pull request to the merge queue Dec 17, 2024
@UebelAndre
Copy link
Collaborator

Oh, but in this case, there was a conflict so the PR became ineligible for the queue.

Merged via the queue into bazelbuild:main with commit 0e2fbbf Dec 17, 2024
3 checks passed
@katre katre deleted the remove_crosstool_files branch December 17, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove use of _cc_toolchain
2 participants