Add context.Context to the Debug reporting method, and all serving/response handling. #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
BTW can you point at good examples of using an "app-scope" context that would be passed in to the top-level Serve? I'm curious but I have never seen an example in open source code that would actually improve anything. I'm extremely unsure what canceling such a context would even mean. |
|
Don't have examples, and we have moved in a different direction - but our motivation was for an application that doesn't mount on startup, and may setup tracing or other variables in the Context for use later in the stack. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
context.Context is useful for tracing, time limiting, and connecting to external systems. Further the use of it by adding to Debug and then all methods that lead to Debug.
This, as a by-product, results in the ability to provide a surrounding Context to Serve(); which previously insisted on Background, making it a better part of a surrounding application.