Fix ical #316
Fix ical #316
Conversation
In case of full day leave, previous implementation was using 0:00...23:59 notation, which by most (if not all) calendar applications were not treated as full day event. Instead each leave was shown as long event, one or more days long. Such visualization cause that calendar view was absolutely unreadable. In case when 'global' were subscribed, and then for example merged with others 'Personal' calendars, one person leave event generates calendar mess. Now full day leaves are reported as full day events, therefore they can/are represented by the applications in special way which are free of previous effect.
Seems there is no need to create another one VCalendar instance and then use it to create VTIMEZONE object. VCalendar object already exist and it can be used here without any problems.
In this same way like in previous commit VEVENT creation can use existing already VCalendar instance instead of creating own temporary object which is useless once VEVENT is created. Here existing VCalendar object is now provided to createVEvent function and it can be used as an factory for VEVENT.
Changed from add_vtimezone to addVTimezone.
By mistake, for every event from 'collaborators' view separate VCalendar object was created which finally returns one(last) calendar object with only one event inside.
|
Hi, Thanks for this PR. Did you test it with Google Calendar and Outlook? In a previous PR the solution was only working with MacOS' client See #218 |
My Jorani instance is working in intranet only, therefore Google Calendar was tested like this:
seems to work, see below. Jorani configuration
Google calendar
and last event details
My Jorani instance is working in intranet, therefore I have no possibility to subscribe this calendar to Google Calendar. That's the reason why ICS file were exported/imported manually. Outlook was not tested (yet), as I'm Linux guy, I have limited access to Windows workstations and Outlook as well. Will try to test it asap (up to 3 days I think). Moreover: Calendar was tested with Thunderbird (where it seems to work, see my previous screenshots).
Here you have much more changes, so I agree I should to be tested carefully. |
|
@bbalet here you can see Outlook test result Configuration at Jorani side
and outlook calendar
It seems to work as well. |
|
Looks good to me. |
This MR is changing the way how 'full day' leaves are represented in ICS calendars.
Instead of "hardcoded" 0:00→23:59 duration, now DTSTART & DTEND fields can use Date (instead of DateTime) notation which gives ical clients possibility to show events/leaves as 'full day' event.
Here you can see the difference
Old visualization
New visualization
This original visualization was (at least for me) extremely annoying. When I wanted to mix two types of calendars: one with my appointments and second with all leaves in my company (so 'global' or 'my subordinates' calendar) generated view was like this
In case when more than one coworker was listed situation was even worst.
About VTIMEZONE
ICS content returned by jorani to the clients were tested by my on https://icalendar.org/validator.html page and this validator complains about missing VTIMEZONE entries. Therefore, this ICAL element were added as well.
This part of code was borrowed from https://gist.github.com/thomascube/47ff7d530244c669825736b10877a200 and only slightly aligned with the rest of jorani software.