`property` of inputs and outputs can be a path #28

forman · 2024-11-10T16:58:50Z

Closes #25

b-yogesh

Looks good! I have added some questions and some suggestions which can be applied before merging.

dashi/src/lib/utils/mapObject.ts

dashi/src/lib/utils/objPath.ts

dashi/src/lib/utils/objPath.test.ts

dashi/src/lib/types/model/callback.ts

dashi/src/lib/api/types.ts

Co-authored-by: b-yogesh <[email protected]>

…rman-25-property_path

forman added 15 commits November 9, 2024 10:30

renamed getValue.ts into objPath.ts: first impl. of setValue()

3b7e609

fixes

7d73684

code cleanup

aeefa07

new helper

a48312e

allow for index as input

362cbf6

allow for transformations

9cbe4ad

transform to normalize "property"

22add16

more tests

90adcc9

make use of getValue/setValue where applicable

253674c

split api.ts

0d7067e

introduced equalObjPaths

d7fe9c2

using ObjPathLike instead of string | ObjPath

38fefa4

make more use of new mapObject

b3b0ad6

oops

c6b404b

refactored api module

b08cbad

forman marked this pull request as ready for review November 11, 2024 10:33

forman requested a review from b-yogesh November 11, 2024 10:33

forman self-assigned this Nov 11, 2024

forman added 7 commits November 11, 2024 12:09

moved event.ts into state/

213f48c

no export

8de59ec

readability improvements

e68ed5a

releasing 0.0.15

744a341

releasing 0.0.15

8b94bec

prefix logging output

0edcecf

no longer memoizing

d45bfc2

b-yogesh approved these changes Nov 11, 2024

View reviewed changes

forman and others added 4 commits November 11, 2024 16:33

Update dashi/src/lib/utils/objPath.ts

b258952

Co-authored-by: b-yogesh <[email protected]>

Update dashi/src/lib/types/model/callback.ts

666b5e3

Co-authored-by: b-yogesh <[email protected]>

moved api/types into types/api

623b531

Merge remote-tracking branch 'origin/forman-25-property_path' into fo…

84bf1f5

…rman-25-property_path

forman requested a review from b-yogesh November 11, 2024 15:43

b-yogesh approved these changes Nov 11, 2024

View reviewed changes

forman merged commit cabd9c6 into main Nov 11, 2024

forman deleted the forman-25-property_path branch November 11, 2024 15:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`property` of inputs and outputs can be a path #28

`property` of inputs and outputs can be a path #28

forman commented Nov 10, 2024

b-yogesh left a comment

property of inputs and outputs can be a path #28

property of inputs and outputs can be a path #28

Conversation

forman commented Nov 10, 2024

b-yogesh left a comment

Choose a reason for hiding this comment

`property` of inputs and outputs can be a path #28

`property` of inputs and outputs can be a path #28